Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Always use the LoadStubCompiler for Load handlers, also for keyedload
handlers.
Port r22551 (0cc23b1)
BUG=
Please review this at https://codereview.chromium.org/415623002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -14 lines):
M src/mips/stub-cache-mips.cc
M src/mips64/stub-cache-mips64.cc
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
5b66a7e9ac7823ad8395929256f7f0d8bb896ea3..0b7241f41400ee838cf9207f028c3ce40fb6cd8a
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -995,13 +995,8 @@ void LoadStubCompiler::GenerateLoadField(Register reg,
FieldIndex field,
Representation representation) {
if (!reg.is(receiver())) __ mov(receiver(), reg);
- if (kind() == Code::LOAD_IC) {
- LoadFieldStub stub(isolate(), field);
- GenerateTailCall(masm(), stub.GetCode());
- } else {
- KeyedLoadFieldStub stub(isolate(), field);
- GenerateTailCall(masm(), stub.GetCode());
- }
+ LoadFieldStub stub(isolate(), field);
+ GenerateTailCall(masm(), stub.GetCode());
}
Index: src/mips64/stub-cache-mips64.cc
diff --git a/src/mips64/stub-cache-mips64.cc
b/src/mips64/stub-cache-mips64.cc
index
82f4696e2ce620e43491a313002b46a245c3b9df..199473797a1850ad6a96300245da48fa61d57d40
100644
--- a/src/mips64/stub-cache-mips64.cc
+++ b/src/mips64/stub-cache-mips64.cc
@@ -996,13 +996,8 @@ void LoadStubCompiler::GenerateLoadField(Register reg,
FieldIndex field,
Representation representation) {
if (!reg.is(receiver())) __ mov(receiver(), reg);
- if (kind() == Code::LOAD_IC) {
- LoadFieldStub stub(isolate(), field);
- GenerateTailCall(masm(), stub.GetCode());
- } else {
- KeyedLoadFieldStub stub(isolate(), field);
- GenerateTailCall(masm(), stub.GetCode());
- }
+ LoadFieldStub stub(isolate(), field);
+ GenerateTailCall(masm(), stub.GetCode());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
