On 2009/08/12 15:07:10, tfarina wrote: > On 2009/08/12 07:04:23, Christian Plesner Hansen wrote: > > I'm unclear on why all the operator*s should return const types. > > > > http://codereview.chromium.org/165208/diff/1/2 > > File include/v8.h (right): > > > > http://codereview.chromium.org/165208/diff/1/2#newcode921 > > Line 921: const char* operator*() const { return str_; } > > Why change the return type to const char*? Note also that this is an > > incompatible change. > I follow the recomendations of this issue: > http://code.google.com/p/v8/issues/detail?id=378 Christian can you update(close) the issue in bug tracker(http://code.google.com/p/v8/issues/detail?id=378)? Then I will close this patch.
http://codereview.chromium.org/165208 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
