LGTM if you fix the test failure (test/mjsunit/regress/regress-1062422.js)
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc#newcode250
src/accessors.cc:250: ASSERT(value->IsJSObject());
As the failing test indicates, this is wrong since you can put this in
the prototype chain of any other primitive value. Just remove this
ASSERT and update the comment.
https://codereview.chromium.org/410923003/diff/20001/src/accessors.cc#newcode987
src/accessors.cc:987: Handle<Object> result =
Handle<Object>(function->shared()->name(), isolate);
You can just write this as Handle<Object>
result(function->shared()->name(), isolate);
https://codereview.chromium.org/410923003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
