Reviewers: jarin,
Message:
PTAL. Maybe more test coverage would have helped to catch these two...
Bug 1: Missing return statement. Variable assignment receives None from
this and
it seams as python treats None like 0 in the later < comparison.
Bug 2: Little too much indentation or the return None statement. Like that
it's
in the loop and always fires in the first round...
Description:
Fix automatic tagging.
BUG=
Please review this at https://codereview.chromium.org/417973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -3 lines):
M tools/push-to-trunk/auto_tag.py
M tools/push-to-trunk/common_includes.py
M tools/push-to-trunk/test_scripts.py
Index: tools/push-to-trunk/auto_tag.py
diff --git a/tools/push-to-trunk/auto_tag.py
b/tools/push-to-trunk/auto_tag.py
index
d2bf9234310e4b137362689183e0b24a548a6e21..6beaaff8a30ddca52693fb2dd4a606c9a4cfdd73
100755
--- a/tools/push-to-trunk/auto_tag.py
+++ b/tools/push-to-trunk/auto_tag.py
@@ -117,7 +117,7 @@ class CalculateTagRevision(Step):
# LKGRs are reverse sorted.
if int(min_rev) <= int(lkgr) and int(lkgr) < int(max_rev):
return lkgr
- return None
+ return None
def RunStep(self):
# Get the lkgr after the tag candidate and before the next tag
candidate.
Index: tools/push-to-trunk/common_includes.py
diff --git a/tools/push-to-trunk/common_includes.py
b/tools/push-to-trunk/common_includes.py
index
d2976022c8274176f604964b24a2879cb71046ee..0e57a25bb14c84318b553174f6e71feb8f181004
100644
--- a/tools/push-to-trunk/common_includes.py
+++ b/tools/push-to-trunk/common_includes.py
@@ -245,7 +245,7 @@ class SideEffectHandler(object): # pragma: no cover
return datetime.date.today().strftime("%Y-%m-%d")
def GetUTCStamp(self):
- time.mktime(datetime.datetime.utcnow().timetuple())
+ return time.mktime(datetime.datetime.utcnow().timetuple())
DEFAULT_SIDE_EFFECT_HANDLER = SideEffectHandler()
Index: tools/push-to-trunk/test_scripts.py
diff --git a/tools/push-to-trunk/test_scripts.py
b/tools/push-to-trunk/test_scripts.py
index
f737076ea72683c1178d0e297bb11924fd51dedd..9752ab7d1e1dda3f415e52dcafd5a15863003638
100644
--- a/tools/push-to-trunk/test_scripts.py
+++ b/tools/push-to-trunk/test_scripts.py
@@ -1373,7 +1373,8 @@ LOG=N
self.ExpectReadURL([
URL("https://v8-status.appspot.com/revisions?format=json";,
- "[{\"revision\": \"123\", \"status\": true},"
+ "[{\"revision\": \"126\", \"status\": true},"
+ "{\"revision\": \"123\", \"status\": true},"
"{\"revision\": \"112\", \"status\": true}]"),
])
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
