lgtm, just nits
https://codereview.chromium.org/412163003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/412163003/diff/1/include/v8.h#newcode4470
include/v8.h:4470: * The idle_time_hint_ms argument specifies the time
V8 has to do reduce
remove one blank in between time V8
https://codereview.chromium.org/412163003/diff/1/include/v8.h#newcode4470
include/v8.h:4470: * The idle_time_hint_ms argument specifies the time
V8 has to do reduce
I would prefer idle_time_in_ms
https://codereview.chromium.org/412163003/diff/1/include/v8.h#newcode4474
include/v8.h:4474: bool IdleNotification(int idle_time_hint_ms);
idle_time_in_ms
https://codereview.chromium.org/412163003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/412163003/diff/1/src/api.cc#newcode6715
src/api.cc:6715: bool v8::Isolate::IdleNotification(int
idle_time_hint_ms) {
idle_time_in_ms
https://codereview.chromium.org/412163003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
