https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (left):
https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc#oldcode366
test/cctest/test-types.cc:366: Rep::IsClass(type1) ==
Rep::IsClass(type2) &&
I don't think these should be removed, but they should use the public
predicates.
https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc#oldcode377
test/cctest/test-types.cc:377: (!Rep::IsClass(type1) ||
Similarly here: use the public getters.
https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):
https://codereview.chromium.org/413983005/diff/1/test/cctest/test-types.cc#newcode341
test/cctest/test-types.cc:341: // TODO(rossberg): Check details of
arrays, functions, bounds.
If you want, please also feel free to flesh out this comment. :)
https://codereview.chromium.org/413983005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
