https://codereview.chromium.org/415953005/diff/1/src/lookup.h
File src/lookup.h (right):
https://codereview.chromium.org/415953005/diff/1/src/lookup.h#newcode100
src/lookup.h:100: Handle<JSObject> GetNonJSProxyHolder() const {
You should call it GetJSObjectHolder.
But I'm not sure I like such random downcast accessors all that much.
How about changing GetHolder to
template<class T>
Handle<T> GetHolder() const {
ASSERT(IsFound());
return Handle<T>::cast(maybe_holder_.ToHandleChecked());
}
https://codereview.chromium.org/415953005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
