Reviewers: Mads Ager, Description: Refactor SetFunctionInfo to reduce long argument list take 2.
It now includes the change to ARM and x64 architectures as well. Please review this at http://codereview.chromium.org/165528 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/codegen-arm.h M src/x64/codegen-x64.h Index: src/x64/codegen-x64.h =================================================================== --- src/x64/codegen-x64.h (revision 2686) +++ src/x64/codegen-x64.h (working copy) @@ -299,14 +299,9 @@ #endif static void SetFunctionInfo(Handle<JSFunction> fun, - int length, - int function_token_position, - int start_position, - int end_position, - bool is_expression, + FunctionLiteral* lit, bool is_toplevel, - Handle<Script> script, - Handle<String> inferred_name); + Handle<Script> script); // Accessors MacroAssembler* masm() { return masm_; } Index: src/arm/codegen-arm.h =================================================================== --- src/arm/codegen-arm.h (revision 2686) +++ src/arm/codegen-arm.h (working copy) @@ -152,14 +152,9 @@ #endif static void SetFunctionInfo(Handle<JSFunction> fun, - int length, - int function_token_position, - int start_position, - int end_position, - bool is_expression, + FunctionLiteral* lit, bool is_toplevel, - Handle<Script> script, - Handle<String> inferred_name); + Handle<Script> script); // Accessors MacroAssembler* masm() { return masm_; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
