DBC
https://codereview.chromium.org/411973002/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/411973002/diff/1/src/ia32/stub-cache-ia32.cc#newcode302
src/ia32/stub-cache-ia32.cc:302: MacroAssembler* masm, const
CallOptimization& optimization,
On 2014/07/24 16:33:47, mvstanton wrote:
nit: I like the old style better, what about starting the arguments on
a new
line, like
void PropertyHandlerCompiler::GenerateFastApiCall(
MacroAssembler* masm,
....
This kind of formatting bikeshedding is gone with "git cl format"... ;-)
Toon's CL is correctly formatted according to that tool, so we should
keep it like it is.
Extended comment: The *real* problem is that functions with 8 arguments
are ugly, unreadable and completely untestable. "Uncle Bob" et. al.
recommend 2-3 arguments at most.
https://codereview.chromium.org/411973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
