LGTM
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc
File test/cctest/test-constantpool.cc (right):
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc#newcode287
test/cctest/test-constantpool.cc:287: factory->NewFixedDoubleArray(900 *
KB / kDoubleSize, TENURED);
add a check that checks if this fixed double array got allocated in old
data space.
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc#newcode290
test/cctest/test-constantpool.cc:290:
CHECK(!heap->InNewSpace(heap_ptr->address()));
change this check to CHECK(heap->InOldDataSpace(heap_ptr->address()));
https://codereview.chromium.org/396803009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
