Revision: 2694
Author: [email protected]
Date: Mon Aug 17 02:07:40 2009
Log: X64: Remove compound smi+overflow test using cmov.
Review URL: http://codereview.chromium.org/165525
http://code.google.com/p/v8/source/detail?r=2694
Modified:
/branches/bleeding_edge/src/x64/codegen-x64.cc
=======================================
--- /branches/bleeding_edge/src/x64/codegen-x64.cc Mon Aug 17 01:02:07 2009
+++ /branches/bleeding_edge/src/x64/codegen-x64.cc Mon Aug 17 02:07:40 2009
@@ -3084,33 +3084,16 @@
is_increment);
}
- // If we have a free register, combine the smi and overflow checks.
- Result tmp = allocator_->AllocateWithoutSpilling();
- ASSERT(kSmiTagMask == 1 && kSmiTag == 0);
- if (tmp.is_valid()) {
- __ movl(tmp.reg(), Immediate(kSmiTagMask));
- }
-
- // Try incrementing or decrementing the smi.
__ movq(kScratchRegister, new_value.reg());
if (is_increment) {
__ addl(kScratchRegister, Immediate(Smi::FromInt(1)));
} else {
__ subl(kScratchRegister, Immediate(Smi::FromInt(1)));
}
-
- // Go to the deferred case if the result overflows or is non-smi.
- if (tmp.is_valid()){
- __ cmovl(overflow, kScratchRegister, tmp.reg());
- __ testl(kScratchRegister, tmp.reg());
- tmp.Unuse();
- deferred->Branch(not_zero);
- } else {
- deferred->Branch(overflow);
- __ testl(kScratchRegister, Immediate(kSmiTagMask));
- deferred->Branch(not_zero);
- }
-
+ // Smi test.
+ deferred->Branch(overflow);
+ __ testl(kScratchRegister, Immediate(kSmiTagMask));
+ deferred->Branch(not_zero);
__ movq(new_value.reg(), kScratchRegister);
deferred->BindExit();
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
