lgtm, just nits
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc
File src/gc-tracer.cc (right):
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc#newcode277
src/gc-tracer.cc:277: PrintF("stepscount=%d ",
current_.incremental_marking_steps);
Since you are here, can we make the names here uniform:
steps_count
steps_took
same in the else case
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc#newcode282
src/gc-tracer.cc:282: PrintF("longeststep=%.1f ",
current_.longest_incremental_marking_step);
Let's print the MarkingSpeedInBytesPerMillisecond here in the else case.
PrintF("marking_throughput=%d\n", MarkingSpeedInBytesPerMillisecond());
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc#newcode320
src/gc-tracer.cc:320: // We haven't complete an entire round of
incremental marking, yet.
completed
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc#newcode343
src/gc-tracer.cc:343: // We haven't complete an entire round of
incremental marking, yet.
completed
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.h
File src/gc-tracer.h (right):
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.h#newcode255
src/gc-tracer.h:255: double MarkingSpeedInBytesPerMillisecond() const;
No need for double here, lets cast it to e.g. intptr_t. I assume that
the result will always be a large number.
https://codereview.chromium.org/420213002/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):
https://codereview.chromium.org/420213002/diff/1/src/incremental-marking.cc#newcode960
src/incremental-marking.cc:960: heap_->AddMarkingTime(duration);
Can we remove the AddMarkingTime call? In a separate CL?
https://codereview.chromium.org/420213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
