lgtm with nit.
You can land the repro separately.
https://codereview.chromium.org/418023002/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/418023002/diff/1/src/arm/code-stubs-arm.cc#newcode2972
src/arm/code-stubs-arm.cc:2972: __ ldr(r5, FieldMemOperand(r4,
AllocationSite::kMapOffset));
HeapObject::kMapOffset?
https://codereview.chromium.org/418023002/diff/1/src/arm64/code-stubs-arm64.cc
File src/arm64/code-stubs-arm64.cc (right):
https://codereview.chromium.org/418023002/diff/1/src/arm64/code-stubs-arm64.cc#newcode3241
src/arm64/code-stubs-arm64.cc:3241: __ Ldr(map, FieldMemOperand(scratch,
AllocationSite::kMapOffset));
HeapObject::kMapOffset?
(You don't know yet whether it's an AllocationSite, just that it's a
HeapObject)
https://codereview.chromium.org/418023002/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/418023002/diff/1/src/ia32/code-stubs-ia32.cc#newcode2383
src/ia32/code-stubs-ia32.cc:2383: __ cmp(FieldOperand(ecx, 0),
factory->allocation_site_map());
HeapObject::kMapoffset?
https://codereview.chromium.org/418023002/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/418023002/diff/1/src/x64/code-stubs-x64.cc#newcode2262
src/x64/code-stubs-x64.cc:2262: __ Cmp(FieldOperand(rcx, 0),
factory->allocation_site_map());
HeapObject::kMapOffset?
https://codereview.chromium.org/418023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
