lgtm, one nit
https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc#newcode4460
test/cctest/test-heap.cc:4460:
SimulateFullSpace(heap->old_pointer_space());
I do not think you need the first fixed array. I guess you can assume
that you have a whole new old space page when you allocate the second
fixed array after calling SimulateFullSpace.
https://codereview.chromium.org/424693006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
