Revision: 22696
Author:   [email protected]
Date:     Wed Jul 30 09:04:42 2014 UTC
Log: X87: Clean up name distinction between Keyed ICs and Element Handlers

port r22679.

original commit message:

  Clean up name distinction between Keyed ICs and Element Handlers

BUG=
[email protected]

Review URL: https://codereview.chromium.org/426083006

Patch from Chunyang Dai <[email protected]>.
http://code.google.com/p/v8/source/detail?r=22696

Modified:
 /branches/bleeding_edge/src/x87/ic-x87.cc
 /branches/bleeding_edge/src/x87/macro-assembler-x87.cc
 /branches/bleeding_edge/src/x87/stub-cache-x87.cc

=======================================
--- /branches/bleeding_edge/src/x87/ic-x87.cc   Wed Jul 23 07:48:19 2014 UTC
+++ /branches/bleeding_edge/src/x87/ic-x87.cc   Wed Jul 30 09:04:42 2014 UTC
@@ -579,9 +579,8 @@
   __ push(scratch);   // return address

   // Perform tail call to the entry.
-  ExternalReference ref =
-      ExternalReference(IC_Utility(kKeyedLoadPropertyWithInterceptor),
-                        masm->isolate());
+  ExternalReference ref = ExternalReference(
+      IC_Utility(kLoadElementWithInterceptor), masm->isolate());
   __ TailCallExternalReference(ref, 2, 1);

   __ bind(&slow);
=======================================
--- /branches/bleeding_edge/src/x87/macro-assembler-x87.cc Tue Jul 29 14:38:39 2014 UTC +++ /branches/bleeding_edge/src/x87/macro-assembler-x87.cc Wed Jul 30 09:04:42 2014 UTC
@@ -1173,7 +1173,7 @@


// Compute the hash code from the untagged key. This must be kept in sync with
-// ComputeIntegerHash in utils.h and KeyedLoadGenericElementStub in
+// ComputeIntegerHash in utils.h and KeyedLoadGenericStub in
 // code-stub-hydrogen.cc
 //
 // Note: r0 will contain hash code
=======================================
--- /branches/bleeding_edge/src/x87/stub-cache-x87.cc Wed Jul 30 08:25:26 2014 UTC +++ /branches/bleeding_edge/src/x87/stub-cache-x87.cc Wed Jul 30 09:04:42 2014 UTC
@@ -1122,8 +1122,8 @@
   __ push(scratch1());  // restore return address

   // Do tail-call to the runtime system.
-  ExternalReference store_ic_property =
- ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate());
+  ExternalReference store_ic_property = ExternalReference(
+      IC_Utility(IC::kStorePropertyWithInterceptor), isolate());
   __ TailCallExternalReference(store_ic_property, 3, 1);

   // Return the generated code.
@@ -1145,7 +1145,7 @@
 }


-Handle<Code> PropertyICCompiler::CompileIndexedStorePolymorphic(
+Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(
     MapHandleList* receiver_maps, CodeHandleList* handler_stubs,
     MapHandleList* transitioned_maps) {
   Label miss;
@@ -1343,7 +1343,7 @@
 #define __ ACCESS_MASM(masm)


-void IndexedHandlerCompiler::GenerateLoadDictionaryElement(
+void ElementHandlerCompiler::GenerateLoadDictionaryElement(
     MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- ecx    : key

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to