lgtm with nits that you can ignore:
https://codereview.chromium.org/426633002/diff/60001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode942
src/ic.cc:942: Handle<HeapType> type = receiver_type();
You replaced half of the |type| usages with the |receiver_type()|. What
about the other half?
https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode1002
src/ic.cc:1002: !info->IsCompatibleReceiver(*map)) {
Consider
!info->IsCompatibleReceiver(TypeToMap(*type, isolate()))
like you did in all the other places.
What about adding IC::IsCompatibleReceiver(info, type) instead of old
AccessorInfo::IsCompatibleReceiver()?
https://codereview.chromium.org/426633002/diff/60001/src/ic.cc#newcode1446
src/ic.cc:1446: !info->IsCompatibleReceiver(*map)) {
Same here.
https://codereview.chromium.org/426633002/diff/60001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/426633002/diff/60001/src/x64/stub-cache-x64.cc#newcode895
src/x64/stub-cache-x64.cc:895: (!callback->HasExpectedReceiverType() ||
It was easier to understand callback->IsCompatibleReceiver(*object) than
this new complex condition.
https://codereview.chromium.org/426633002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
