Revision: 22703
Author:   [email protected]
Date:     Wed Jul 30 11:41:48 2014 UTC
Log:      Drop deprecated memory related notification API

Embedders should use the non-static methods on Isolate with the same
name.

BUG=397026
[email protected]
LOG=y

Review URL: https://codereview.chromium.org/429593003
http://code.google.com/p/v8/source/detail?r=22703

Modified:
 /branches/bleeding_edge/include/v8.h
 /branches/bleeding_edge/src/api.cc

=======================================
--- /branches/bleeding_edge/include/v8.h        Tue Jul 29 17:02:52 2014 UTC
+++ /branches/bleeding_edge/include/v8.h        Wed Jul 30 11:41:48 2014 UTC
@@ -4993,40 +4993,6 @@
   static void VisitHandlesForPartialDependence(
       Isolate* isolate, PersistentHandleVisitor* visitor);

-  /**
-   * Optional notification that the embedder is idle.
-   * V8 uses the notification to reduce memory footprint.
-   * This call can be used repeatedly if the embedder remains idle.
-   * Returns true if the embedder should stop calling IdleNotification
-   * until real work has been done.  This indicates that V8 has done
-   * as much cleanup as it will be able to do.
-   *
- * The hint argument specifies the amount of work to be done in the function - * on scale from 1 to 1000. There is no guarantee that the actual work will
-   * match the hint.
-   *
-   * Deprecated, please use Isolate::IdleNotification.
-   */
-  static bool IdleNotification(int hint = 1000);
-
-  /**
-   * Optional notification that the system is running low on memory.
-   * V8 uses these notifications to attempt to free memory.
-   *
-   * Deprecated, please use Isolate::LowMemoryNotification.
-   */
-  static void LowMemoryNotification();
-
-  /**
-   * Optional notification that a context has been disposed. V8 uses
-   * these notifications to guide the GC heuristic. Returns the number
-   * of context disposals - including this one - since the last time
-   * V8 had a chance to clean up.
-   *
-   * Deprecated, please use Isolate::ContextDisposedNotification.
-   */
-  static int ContextDisposedNotification();
-
   /**
    * Initialize the ICU library bundled with V8. The embedder should only
* invoke this method when using the bundled ICU. Returns true on success.
=======================================
--- /branches/bleeding_edge/src/api.cc  Fri Jul 25 18:32:11 2014 UTC
+++ /branches/bleeding_edge/src/api.cc  Wed Jul 30 11:41:48 2014 UTC
@@ -5076,34 +5076,6 @@
   isolate->global_handles()->IterateAllRootsInNewSpaceWithClassIds(
       &visitor_adapter);
 }
-
-
-bool v8::V8::IdleNotification(int hint) {
-  // Returning true tells the caller that it need not
-  // continue to call IdleNotification.
-  i::Isolate* isolate = i::Isolate::Current();
-  if (isolate == NULL || !isolate->IsInitialized()) return true;
-  if (!i::FLAG_use_idle_notification) return true;
-  return isolate->heap()->IdleNotification(hint);
-}
-
-
-void v8::V8::LowMemoryNotification() {
-  i::Isolate* isolate = i::Isolate::Current();
-  if (isolate == NULL || !isolate->IsInitialized()) return;
-  {
-    i::HistogramTimerScope idle_notification_scope(
-        isolate->counters()->gc_low_memory_notification());
-    isolate->heap()->CollectAllAvailableGarbage("low memory notification");
-  }
-}
-
-
-int v8::V8::ContextDisposedNotification() {
-  i::Isolate* isolate = i::Isolate::Current();
-  if (!isolate->IsInitialized()) return 0;
-  return isolate->heap()->NotifyContextDisposed();
-}


 bool v8::V8::InitializeICU(const char* icu_data_file) {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to