https://codereview.chromium.org/423303006/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4292
src/heap.cc:4292: int remaining_time =
AdvanceIdleIncrementalMarking(step_size);
On 2014/07/30 10:33:26, ernstm wrote:
Isn't the value returned by AdvanceIdleIncrementalMarking the time we
already
spent? Maybe rename remaining_time to time_elapsed?

yes, that makes sense. actually, we should use the tracer and not a
custom timer here. WDYT?

https://codereview.chromium.org/423303006/diff/1/src/heap.cc#newcode4340
src/heap.cc:4340: int remaining_time =
AdvanceIdleIncrementalMarking(step_size);
On 2014/07/30 10:33:26, ernstm wrote:
remaining_time -> time_elapsed?

yes.

https://codereview.chromium.org/423303006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to