Status: Accepted Owner: ---- Labels: Type-FeatureRequest Priority-Low New issue 428 by [email protected]: Use of static variable builtin_passed_function should be removed. http://code.google.com/p/v8/issues/detail?id=428
To call a C callback, created by the API, we use the Builtins object and CEntryStub. The caller is passed in the global static builtin_passed_function. We should call C callbacks with separate code than that used to call C builtins, since they do not return GC request failures, and drop this global static. If we do this, then the gc-greedy flag can do a GC before the first call to a C function in CEntryStub. The earlier bug said: We need to clean up the way we call builtin functions in builtins.cc file. Ideally, we should be able to call the C function with the following parameters correctly set (even in the presence of an argument adaptor frame): int argc : number of arguments passed by caller Object** argv : pointer to first argument, e.g. f(1,2,3) -> argv[0] = 1, argv[-1] = 2, argv[-2] = 3 Handle<Object> : receiver Handle<JSFunction> : callee function bool is_construct : is the callee function called through 'new'? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
