LGTM, modulo the src/compiler/compiler directory as discussed.
https://codereview.chromium.org/426233002/diff/1/src/lithium-inl.h
File src/lithium-inl.h (right):
https://codereview.chromium.org/426233002/diff/1/src/lithium-inl.h#newcode6
src/lithium-inl.h:6: // * Redistributions of source code must retain
the above copyright
Let's switch to the short copyright header.
https://codereview.chromium.org/426233002/diff/1/src/lithium-inl.h#newcode41
src/lithium-inl.h:41: #elif V8_TARGET_ARCH_A64
The #ifdef for A64 should be dropped, must have snuck in.
https://codereview.chromium.org/426233002/diff/1/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):
https://codereview.chromium.org/426233002/diff/1/test/cctest/cctest.gyp#newcode105
test/cctest/cctest.gyp:105: 'test-checks.cc',
nit: Let's drop the second occurrence of this file.
https://codereview.chromium.org/426233002/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/426233002/diff/1/test/cctest/cctest.status#newcode80
test/cctest/cctest.status:80: # Tritium compiler failures.
nit: s/Tritium/TurboFan/
https://codereview.chromium.org/426233002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/426233002/diff/1/test/cctest/test-parsing.cc#newcode3023
test/cctest/test-parsing.cc:3023: // Used to trigger lazy compilation of
function
This comment should got to line 3108 below I think.
https://codereview.chromium.org/426233002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/426233002/diff/1/tools/run-tests.py#newcode65
tools/run-tests.py:65: VARIANTS = ["default", "stress", "turbofan",
"nocrankshaft"]
As discussed, let's drop the new variant from the VARIANTS list and
enable it separately in another CL.
https://codereview.chromium.org/426233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
