On 2009/08/18 09:34:56, Kasper Lund wrote: > LGTM, but I noticed similar code on x64. Apparently, it is possible (yet > unlikely) to have an x64 chip with no SSE3 support, so you need to fix that too.
Good point, done. > Maybe while you're at it, you should double check that > CpuFeatures::IsSupported(CpuFeatures::SSE3) returns what you expect on x64 > platforms? Double checked. The x64 probing code looks fine. The regression is there and it is fixed by these changes. Thanks! http://codereview.chromium.org/172086 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
