[v8-dev] MIPS: Remove keyed_store_calling convention and friends. (issue 429893006 by [email protected])

Wed, 30 Jul 2014 10:31:03 -0700

Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec, dusmil.imgtec, 

Description:
MIPS: Remove keyed_store_calling convention and friends.

BUG=

Please review this at https://codereview.chromium.org/429893006/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+3, -51 lines):
  M src/mips/ic-mips.cc
  M src/mips/stub-cache-mips.cc
  M src/mips64/ic-mips64.cc
  M src/mips64/stub-cache-mips64.cc


Index: src/mips/ic-mips.cc
diff --git a/src/mips/ic-mips.cc b/src/mips/ic-mips.cc
index d5e60c452ed2f87b6b3db204550e21c5ec14aa09..4d34fc4e59d59aaa5fb6b971401a81dab0395e6c 100644 
--- a/src/mips/ic-mips.cc
+++ b/src/mips/ic-mips.cc
@@ -529,21 +529,6 @@ const Register StoreIC::NameRegister() { return a2; }
 const Register StoreIC::ValueRegister() { return a0; }


-const Register KeyedStoreIC::ReceiverRegister() {
-  return StoreIC::ReceiverRegister();
-}
-
-
-const Register KeyedStoreIC::NameRegister() {
-  return StoreIC::NameRegister();
-}
-
-
-const Register KeyedStoreIC::ValueRegister() {
-  return StoreIC::ValueRegister();
-}
-
-
 const Register KeyedStoreIC::MapRegister() {
   return a3;
 }
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index d8891b57d665e0c790a491fe986facb88f4ebc37..e2ab36d4859b23fe28d67a50061cae8acbec63e1 100644 
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -1156,21 +1156,12 @@ Register* PropertyAccessCompiler::store_calling_convention() { 
   // receiver, name, scratch1, scratch2, scratch3.
   Register receiver = StoreIC::ReceiverRegister();
   Register name = StoreIC::NameRegister();
+  ASSERT(a3.is(KeyedStoreIC::MapRegister()));
   static Register registers[] = { receiver, name, a3, t0, t1 };
   return registers;
 }


-Register* PropertyAccessCompiler::keyed_store_calling_convention() {
-  // receiver, name, scratch1/map, scratch2, scratch3.
-  Register receiver = KeyedStoreIC::ReceiverRegister();
-  Register name = KeyedStoreIC::NameRegister();
-  Register map = KeyedStoreIC::MapRegister();
-  static Register registers[] = { receiver, name, map, t0, t1 };
-  return registers;
-}
-
-
Register NamedStoreHandlerCompiler::value() { return StoreIC::ValueRegister(); } 


Index: src/mips64/ic-mips64.cc
diff --git a/src/mips64/ic-mips64.cc b/src/mips64/ic-mips64.cc
index 317e446c785de0dd28ee3dc5631c6cc61c69fb43..9f82945eda3b907b13568b0690ed87948f3fa44c 100644 
--- a/src/mips64/ic-mips64.cc
+++ b/src/mips64/ic-mips64.cc
@@ -523,26 +523,11 @@ const Register LoadIC::VectorRegister() {
 }


-  const Register StoreIC::ReceiverRegister() { return a1; }
+const Register StoreIC::ReceiverRegister() { return a1; }
 const Register StoreIC::NameRegister() { return a2; }
 const Register StoreIC::ValueRegister() { return a0; }


-const Register KeyedStoreIC::ReceiverRegister() {
-  return StoreIC::ReceiverRegister();
-}
-
-
-const Register KeyedStoreIC::NameRegister() {
-  return StoreIC::NameRegister();
-}
-
-
-const Register KeyedStoreIC::ValueRegister() {
-  return StoreIC::ValueRegister();
-}
-
-
 const Register KeyedStoreIC::MapRegister() {
   return a3;
 }
Index: src/mips64/stub-cache-mips64.cc
diff --git a/src/mips64/stub-cache-mips64.cc b/src/mips64/stub-cache-mips64.cc index ac3a5cf3c4deb71cb0e1456d5fe9e076cc40c038..25e2823ffb4d116811ea3f4c00eaa68f4d84a396 100644 
--- a/src/mips64/stub-cache-mips64.cc
+++ b/src/mips64/stub-cache-mips64.cc
@@ -1157,21 +1157,12 @@ Register* PropertyAccessCompiler::store_calling_convention() { 
   // receiver, name, scratch1, scratch2, scratch3.
   Register receiver = StoreIC::ReceiverRegister();
   Register name = StoreIC::NameRegister();
+  ASSERT(a3.is(KeyedStoreIC::MapRegister()));
   static Register registers[] = { receiver, name, a3, a4, a5 };
   return registers;
 }


-Register* PropertyAccessCompiler::keyed_store_calling_convention() {
-  // receiver, name, scratch1/map, scratch2, scratch3.
-  Register receiver = KeyedStoreIC::ReceiverRegister();
-  Register name = KeyedStoreIC::NameRegister();
-  Register map = KeyedStoreIC::MapRegister();
-  static Register registers[] = { receiver, name, map, a4, a5 };
-  return registers;
-}
-
-
Register NamedStoreHandlerCompiler::value() { return StoreIC::ValueRegister(); } 




--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to