Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r22744 (tree was closed).
Description:
Fix detection of UBFX in case of Word32And with immediate.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=22744
Please review this at https://codereview.chromium.org/438563002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/compiler/arm/instruction-selector-arm.cc
Index: src/compiler/arm/instruction-selector-arm.cc
diff --git a/src/compiler/arm/instruction-selector-arm.cc
b/src/compiler/arm/instruction-selector-arm.cc
index
03b0565487017a836ab5495016d06971ba1184f9..6f8c22fb9076a0771d193d13c67b9c149b3361ed
100644
--- a/src/compiler/arm/instruction-selector-arm.cc
+++ b/src/compiler/arm/instruction-selector-arm.cc
@@ -418,7 +418,7 @@ void InstructionSelector::VisitWord32And(Node* node) {
uint32_t value = m.right().Value();
uint32_t width = CompilerIntrinsics::CountSetBits(value);
uint32_t msb = CompilerIntrinsics::CountLeadingZeros(value);
- if (msb + width == 32) {
+ if (width != 0 && msb + width == 32) {
ASSERT_EQ(0, CompilerIntrinsics::CountTrailingZeros(value));
if (m.left().IsWord32Shr()) {
Int32BinopMatcher mleft(m.left().node());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
