lgtm other than being wrong
https://codereview.chromium.org/433853002/diff/1/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right):
https://codereview.chromium.org/433853002/diff/1/src/compiler/js-generic-lowering.cc#newcode373
src/compiler/js-generic-lowering.cc:373: for (int i = 0; i <
access.depth(); ++i) {
Please leave a TODO here because I think we want to lower this to
SimplifiedOperators first so that we have a little more information for
GVN and load/store elimination.
https://codereview.chromium.org/433853002/diff/1/src/compiler/js-generic-lowering.cc#newcode376
src/compiler/js-generic-lowering.cc:376:
machine()->Load(machine()->word()),
You need kMachineTagged here, otherwise the register allocator won't
track it as a pointer.
https://codereview.chromium.org/433853002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
