http://codereview.chromium.org/173003/diff/1/2
File src/ia32/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/173003/diff/1/2#newcode41
Line 41: #ifdef V8_NATIVE_REGEXP
If we don't use native regexps, this file should not be compiled at all.
The scons and gyp files should work like this *cross fingers*. How are
you building to have a problem here?

http://codereview.chromium.org/173003/diff/1/3
File src/ia32/regexp-macro-assembler-ia32.h (right):

http://codereview.chromium.org/173003/diff/1/3#newcode34
Line 34: #ifndef V8_NATIVE_REGEXP
If we don't use native regexps then we shouldn't include
regexp-macro-assembler-ia32.h at all. If we do, it is an error, but it
should be fixed by ifdef'ing the include instead.

http://codereview.chromium.org/173003

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to