LGTM with comment.
https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi#newcode464
build/toolchain.gypi:464: ['OS=="win" and target_arch=="ia32"', {
better use v8_target_arch. It shouldn't make a difference in this case,
but is more consistent with most other arch checks we do.
https://codereview.chromium.org/432863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
