Reviewers: titzer,
Description:
Extend TF test coverage to supported targets.
[email protected]
TEST=all
Please review this at https://codereview.chromium.org/432313002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -4 lines):
M src/compiler.cc
M src/compiler/pipeline.cc
M tools/run-tests.py
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
962e7923e688b7fc4744358a1883c90bd3999a40..6d22db2dfba8cd00ab71999ae773dcd834799ffe
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -413,10 +413,14 @@ OptimizedCompileJob::Status
OptimizedCompileJob::CreateGraph() {
info()->function()->dont_optimize_reason() != kTryCatchStatement &&
info()->function()->dont_optimize_reason() != kTryFinallyStatement &&
// TODO(turbofan): Make OSR work and remove this bailout.
- !info()->is_osr()) {
+ !info()->is_osr() &&
+ // TODO(mstarzinger): Extend test coverage to unsupported targets.
+ compiler::Pipeline::SupportedTarget()) {
compiler::Pipeline pipeline(info());
pipeline.GenerateCode();
- return SetLastStatus(SUCCEEDED);
+ if (!info()->code().is_null()) {
+ return SetLastStatus(SUCCEEDED);
+ }
}
if (FLAG_trace_hydrogen) {
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index
ef071bba8452a1aa354a0530437f238957624194..7a0460807d3274b970596d7d23a12de9104e60f6
100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -170,7 +170,7 @@ Handle<Code> Pipeline::GenerateCode() {
}
}
- {
+ if (SupportedTarget()) {
// Lower any remaining generic JSOperators.
PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH,
"generic lowering");
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
cbc6116f892035f6c8392444618154df25350081..5484b3f0472f51976c403852b8fa55b0b4f5bba7
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -62,7 +62,7 @@ VARIANT_FLAGS = {
"turbofan": ["--turbo-filter=*", "--always-opt"],
"nocrankshaft": ["--nocrankshaft"]}
-VARIANTS = ["default", "stress", "nocrankshaft"]
+VARIANTS = ["default", "stress", "turbofan", "nocrankshaft"]
MODE_FLAGS = {
"debug" : ["--nohard-abort", "--nodead-code-elimination",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
