Reviewers: titzer,
Description:
Extend TF test coverage to unsupported targets.
[email protected]
TEST=all
Please review this at https://codereview.chromium.org/416233003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -20 lines):
M src/compiler.cc
M src/compiler/pipeline.cc
M test/mjsunit/mjsunit.status
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
6d22db2dfba8cd00ab71999ae773dcd834799ffe..342ed8a7069803f5660f4eb47faf2fa33e17ebd7
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -413,9 +413,7 @@ OptimizedCompileJob::Status
OptimizedCompileJob::CreateGraph() {
info()->function()->dont_optimize_reason() != kTryCatchStatement &&
info()->function()->dont_optimize_reason() != kTryFinallyStatement &&
// TODO(turbofan): Make OSR work and remove this bailout.
- !info()->is_osr() &&
- // TODO(mstarzinger): Extend test coverage to unsupported targets.
- compiler::Pipeline::SupportedTarget()) {
+ !info()->is_osr()) {
compiler::Pipeline pipeline(info());
pipeline.GenerateCode();
if (!info()->code().is_null()) {
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index
7a0460807d3274b970596d7d23a12de9104e60f6..382ee86d946e238094c599882c69d156e762525b
100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -170,23 +170,23 @@ Handle<Code> Pipeline::GenerateCode() {
}
}
+ Handle<Code> code = Handle<Code>::null();
if (SupportedTarget()) {
- // Lower any remaining generic JSOperators.
- PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH,
- "generic lowering");
- MachineOperatorBuilder machine(zone());
- JSGenericLowering lowering(info(), &jsgraph, &machine,
&source_positions);
- lowering.LowerAllNodes();
-
- VerifyAndPrintGraph(&graph, "Lowered generic");
- }
+ {
+ // Lower any remaining generic JSOperators.
+ PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH,
+ "generic lowering");
+ MachineOperatorBuilder machine(zone());
+ JSGenericLowering lowering(info(), &jsgraph, &machine,
&source_positions);
+ lowering.LowerAllNodes();
- // Compute a schedule.
- Schedule* schedule = ComputeSchedule(&graph);
- TraceSchedule(schedule);
+ VerifyAndPrintGraph(&graph, "Lowered generic");
+ }
+
+ // Compute a schedule.
+ Schedule* schedule = ComputeSchedule(&graph);
+ TraceSchedule(schedule);
- Handle<Code> code = Handle<Code>::null();
- if (SupportedTarget()) {
{
// Generate optimized code.
PhaseStats codegen_stats(info(), PhaseStats::CODEGEN, "codegen");
@@ -194,6 +194,7 @@ Handle<Code> Pipeline::GenerateCode() {
code = GenerateCode(&linkage, &graph, schedule, &source_positions);
info()->SetCode(code);
}
+
// Print optimized code.
v8::internal::CodeGenerator::PrintCode(code, info());
}
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
a4f6eb0009c4c549520ca95181fcacd53dfff873..8f01c2d31525cf8cf78f58f3d077d80fc5817549
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -181,9 +181,6 @@
# No need to waste time for this test.
'd8-performance-now': [PASS, NO_VARIANTS],
-
##############################################################################
- 'big-object-literal': [PASS, ['arch == arm or arch == android_arm or
arch == android_arm64', SKIP]],
-
# Issue 488: this test sometimes times out.
'array-constructor': [PASS, TIMEOUT],
@@ -310,6 +307,7 @@
# Pass but take too long to run. Skip.
# Some similar tests (with fewer iterations) may be included in arm64-js
# tests.
+ 'big-object-literal': [SKIP],
'compiler/regress-arguments': [SKIP],
'compiler/regress-gvn': [SKIP],
'compiler/regress-max-locals-for-osr': [SKIP],
@@ -413,6 +411,7 @@
# Long running tests. Skipping because having them timeout takes too
long on
# the buildbot.
+ 'big-object-literal': [SKIP],
'compiler/alloc-number': [SKIP],
'regress/regress-490': [SKIP],
'regress/regress-634': [SKIP],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
