https://codereview.chromium.org/416213004/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode61
src/promise.js:61: %DebugPromiseEvent({ promise: promise,
On 2014/08/01 13:22:21, aandrey wrote:
nit: can it be a one liner now?
Thanks! Fixed it.
https://codereview.chromium.org/416213004/diff/60001/src/promise.js#newcode238
src/promise.js:238: %DebugPromiseEvent({ promise: deferred.promise,
On 2014/08/01 13:22:21, aandrey wrote:
ditto
Done.
https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-promise-events.js
File test/mjsunit/es6/debug-promise-events.js (right):
https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-promise-events.js#newcode44
test/mjsunit/es6/debug-promise-events.js:44:
assertTrue(event_data.promise().isPromise());
On 2014/08/01 13:22:21, aandrey wrote:
code dup x3
Done.
https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-promise-events.js#newcode64
test/mjsunit/es6/debug-promise-events.js:64: var p4 = p3.then();
On 2014/08/01 13:22:21, aandrey wrote:
there is still no tree of promises, isn't it? maybe test this also?
Done.
https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-promise-events.js#newcode66
test/mjsunit/es6/debug-promise-events.js:66: function assertOrAbort(b,
s) {
On 2014/08/01 13:22:21, aandrey wrote:
can we use same name from where it's copied, to ease code search
Done.
https://codereview.chromium.org/416213004/diff/60001/test/mjsunit/es6/debug-promise-events.js#newcode78
test/mjsunit/es6/debug-promise-events.js:78: function() {
On 2014/08/01 13:22:21, aandrey wrote:
extract this function to top level
Done.
https://codereview.chromium.org/416213004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
