On 2014/08/01 15:19:53, Toon Verwaest wrote:
This patch is at least incomplete since it skips the LookupIterator
entirely.
What's the rationale behind this patch? Is this an alternative to having
interceptors that first check for "real" properties?
This patch is try to improve the HTMLCollection.length binding performance.
HTMLCollection has the NamedPropertyHandler(so we can code js like below:)
elem1 = document.forms["myForm"]; // document.forms return HTMLCollection,
with
the NamedPropertyHandler callback, we can get the element by specifying an
item
name
elem2 = document.forms.namedItem("myForm");
But for the real name "length", it always first go to the interceptor, in
the
interceptor callback, it find the length is the real name(by call
HasRealNamedProperty(), in
out/Debug/gen/blink/bindings/core/v8/V8HTMLCollection.cpp), and it fails,
later
it fallback to the real name getter. it leads to much overhead of name
lookup.
So we try to add a flag to disable the interceptor for "length" name(another
patch to disable the interceptor is in blink part).
https://codereview.chromium.org/414213002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
