Reviewers: Yang,
Message:
PTAL.
Description:
Update test expectations for mjsunit/tools/tickprocessor
Please review this at https://codereview.chromium.org/440673002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+34, -29 lines):
M test/mjsunit/mjsunit.status
M test/mjsunit/tools/tickprocessor.js
M test/mjsunit/tools/tickprocessor-test.default
M test/mjsunit/tools/tickprocessor-test.func-info
M test/mjsunit/tools/tickprocessor-test.gc-state
M test/mjsunit/tools/tickprocessor-test.ignore-unknown
M test/mjsunit/tools/tickprocessor-test.separate-ic
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
8f01c2d31525cf8cf78f58f3d077d80fc5817549..c32264486df9d9d191d3e097fd1f7f67021ad6a0
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -207,7 +207,7 @@
# get the same random seed and would generate the same directory name.
Besides
# that, it doesn't make sense to run several variants of d8-os anyways.
'd8-os': [PASS, NO_VARIANTS, ['isolates or arch == android_arm or arch
== android_arm64 or arch == android_ia32', SKIP]],
- 'tools/tickprocessor': [PASS, ['arch == android_arm or arch ==
android_arm64 or arch == android_ia32', SKIP]],
+ 'tools/tickprocessor': [PASS, NO_VARIANTS, ['arch == android_arm or arch
== android_arm64 or arch == android_ia32', SKIP]],
##############################################################################
# Long running test that reproduces memory leak and should be run
manually.
Index: test/mjsunit/tools/tickprocessor-test.default
diff --git a/test/mjsunit/tools/tickprocessor-test.default
b/test/mjsunit/tools/tickprocessor-test.default
index
8ab17c3efbc5b70d53e6425080603434a09f730e..3e01532ac374553bfb460cbdecc31dde24685110
100644
--- a/test/mjsunit/tools/tickprocessor-test.default
+++ b/test/mjsunit/tools/tickprocessor-test.default
@@ -1,13 +1,9 @@
Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0
excluded).
- [Unknown]:
- ticks total nonlib name
- 2 15.4%
-
[Shared libraries]:
ticks total nonlib name
- 3 23.1% 0.0% /lib32/libm-2.7.so
- 1 7.7% 0.0% ffffe000-fffff000
+ 3 23.1% /lib32/libm-2.7.so
+ 1 7.7% ffffe000-fffff000
[JavaScript]:
ticks total nonlib name
@@ -20,9 +16,13 @@ Statistical profiling result from v8.log, (13 ticks, 2
unaccounted, 0 excluded).
1 7.7% 11.1%
v8::internal::HashTable<v8::internal::StringDictionaryShape,
v8::internal::String*>::FindEntry(v8::internal::String*)
1 7.7% 11.1% exp
- [GC]:
+ [Summary]:
ticks total nonlib name
- 0 0.0%
+ 1 7.7% 11.1% JavaScript
+ 5 38.5% 55.6% C++
+ 0 0.0% 0.0% GC
+ 4 30.8% Shared libraries
+ 2 15.4% Unaccounted
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
Index: test/mjsunit/tools/tickprocessor-test.func-info
diff --git a/test/mjsunit/tools/tickprocessor-test.func-info
b/test/mjsunit/tools/tickprocessor-test.func-info
index
a66b90f4c534620312f27fab388030dc98accfa6..c93b6ec701c14fd34ed469b85d8dda3cb918e285
100644
--- a/test/mjsunit/tools/tickprocessor-test.func-info
+++ b/test/mjsunit/tools/tickprocessor-test.func-info
@@ -11,9 +11,12 @@ Statistical profiling result from v8.log, (3 ticks, 0
unaccounted, 0 excluded).
[C++]:
ticks total nonlib name
- [GC]:
+ [Summary]:
ticks total nonlib name
- 0 0.0%
+ 3 100.0% 100.0% JavaScript
+ 0 0.0% 0.0% C++
+ 0 0.0% 0.0% GC
+ 0 0.0% Shared libraries
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
Index: test/mjsunit/tools/tickprocessor-test.gc-state
diff --git a/test/mjsunit/tools/tickprocessor-test.gc-state
b/test/mjsunit/tools/tickprocessor-test.gc-state
index
40f90db4f76e29d55c87a440dc277b061be5c81a..6b1a6a3b3063f5af009ff249ac4846ccbe977362
100644
--- a/test/mjsunit/tools/tickprocessor-test.gc-state
+++ b/test/mjsunit/tools/tickprocessor-test.gc-state
@@ -9,9 +9,12 @@ Statistical profiling result from v8.log, (13 ticks, 0
unaccounted, 13 excluded)
[C++]:
ticks total nonlib name
- [GC]:
+ [Summary]:
ticks total nonlib name
- 0 0.0%
+ 0 0.0% 0.0% JavaScript
+ 0 0.0% 0.0% C++
+ 0 0.0% 0.0% GC
+ 0 0.0% Shared libraries
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
Index: test/mjsunit/tools/tickprocessor-test.ignore-unknown
diff --git a/test/mjsunit/tools/tickprocessor-test.ignore-unknown
b/test/mjsunit/tools/tickprocessor-test.ignore-unknown
index
677da9c9c329eb1bc7409377187c4255952033b9..de70527f9dc905e23cff3650af3a7fec28154dff
100644
--- a/test/mjsunit/tools/tickprocessor-test.ignore-unknown
+++ b/test/mjsunit/tools/tickprocessor-test.ignore-unknown
@@ -2,8 +2,8 @@ Statistical profiling result from v8.log, (13 ticks, 2
unaccounted, 0 excluded).
[Shared libraries]:
ticks total nonlib name
- 3 27.3% 0.0% /lib32/libm-2.7.so
- 1 9.1% 0.0% ffffe000-fffff000
+ 3 27.3% /lib32/libm-2.7.so
+ 1 9.1% ffffe000-fffff000
[JavaScript]:
ticks total nonlib name
@@ -16,9 +16,12 @@ Statistical profiling result from v8.log, (13 ticks, 2
unaccounted, 0 excluded).
1 9.1% 14.3%
v8::internal::HashTable<v8::internal::StringDictionaryShape,
v8::internal::String*>::FindEntry(v8::internal::String*)
1 9.1% 14.3% exp
- [GC]:
+ [Summary]:
ticks total nonlib name
- 0 0.0%
+ 1 9.1% 14.3% JavaScript
+ 5 45.5% 71.4% C++
+ 0 0.0% 0.0% GC
+ 4 36.4% Shared libraries
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
Index: test/mjsunit/tools/tickprocessor-test.separate-ic
diff --git a/test/mjsunit/tools/tickprocessor-test.separate-ic
b/test/mjsunit/tools/tickprocessor-test.separate-ic
index
2d49f737edce6ed4d0de54e82b17501fc3bf8ab8..119ccbe71264cf2160ac959f1056b8040a57ac4f
100644
--- a/test/mjsunit/tools/tickprocessor-test.separate-ic
+++ b/test/mjsunit/tools/tickprocessor-test.separate-ic
@@ -1,13 +1,9 @@
Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0
excluded).
- [Unknown]:
- ticks total nonlib name
- 2 15.4%
-
[Shared libraries]:
ticks total nonlib name
- 3 23.1% 0.0% /lib32/libm-2.7.so
- 1 7.7% 0.0% ffffe000-fffff000
+ 3 23.1% /lib32/libm-2.7.so
+ 1 7.7% ffffe000-fffff000
[JavaScript]:
ticks total nonlib name
@@ -22,9 +18,13 @@ Statistical profiling result from v8.log, (13 ticks, 2
unaccounted, 0 excluded).
1 7.7% 11.1%
v8::internal::HashTable<v8::internal::StringDictionaryShape,
v8::internal::String*>::FindEntry(v8::internal::String*)
1 7.7% 11.1% exp
- [GC]:
+ [Summary]:
ticks total nonlib name
- 0 0.0%
+ 3 23.1% 33.3% JavaScript
+ 5 38.5% 55.6% C++
+ 0 0.0% 0.0% GC
+ 4 30.8% Shared libraries
+ 2 15.4% Unaccounted
[Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total
Index: test/mjsunit/tools/tickprocessor.js
diff --git a/test/mjsunit/tools/tickprocessor.js
b/test/mjsunit/tools/tickprocessor.js
index
78a7c43c62e97bd57934822952d6e3f0dd67b812..f460d349bb553a7d98b08aba3fff3d9cd40d6359
100644
--- a/test/mjsunit/tools/tickprocessor.js
+++ b/test/mjsunit/tools/tickprocessor.js
@@ -25,10 +25,6 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// This test case is not compatible with optimization stress because the
-// generated profile will look vastly different when more is optimized.
-// Flags: --nostress-opt --noalways-opt
-
// Load implementations from <project root>/tools.
// Files: tools/splaytree.js tools/codemap.js tools/csvparser.js
// Files: tools/consarray.js tools/profile.js tools/profile_view.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
