On 2014/08/04 14:09:58, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc
File test/cctest/compiler/test-simplified-lowering.cc (right):
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode399
test/cctest/compiler/test-simplified-lowering.cc:399: Smi* smis[] =
{Smi::FromInt(1), Smi::FromInt(2), Smi::FromInt(3),
suggestion: We could memset the array to canary values on each iteration
of
the
i-j-loop and at the end (after the k-loop) memcmp that all element except
the
one we tested against is untouched. Not sure whether it's worth it though.
Can't trust myself today....
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode417
test/cctest/compiler/test-simplified-lowering.cc:417: printf("i = %ld, j =
%ld\n", i, j);
nit: Looks like a leftover.
Done.
https://codereview.chromium.org/415403008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
