Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as 22833 (tree was closed).
Description:
Fix Object-getOwnPropertyNames test after turning on Symbols
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=22833
Please review this at https://codereview.chromium.org/438103002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M test/webkit/fast/js/Object-getOwnPropertyNames.js
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
Index: test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
index
0947e7c135987819050fe0cb065f34750ee5c459..b47f8b21f726762e3de870bd23a9d3c4ae9b4239
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
@@ -63,7 +63,7 @@ FAIL getSortedOwnPropertyNames(decodeURI) should be
length,name. Was arguments,c
FAIL getSortedOwnPropertyNames(decodeURIComponent) should be length,name.
Was arguments,caller,length,name.
FAIL getSortedOwnPropertyNames(encodeURI) should be length,name. Was
arguments,caller,length,name.
FAIL getSortedOwnPropertyNames(encodeURIComponent) should be length,name.
Was arguments,caller,length,name.
-FAIL getSortedOwnPropertyNames(Object) should be
create,defineProperties,defineProperty,freeze,getOwnPropertyDescriptor,getOwnPropertyNames,getPrototypeOf,isExtensible,isFrozen,isSealed,keys,length,name,preventExtensions,prototype,seal,setPrototypeOf.
Was
arguments,caller,create,defineProperties,defineProperty,deliverChangeRecords,freeze,getNotifier,getOwnPropertyDescriptor,getOwnPropertyNames,getPrototypeOf,is,isExtensible,isFrozen,isSealed,keys,length,name,observe,preventExtensions,prototype,seal,setPrototypeOf,unobserve.
+FAIL getSortedOwnPropertyNames(Object) should be
create,defineProperties,defineProperty,freeze,getOwnPropertyDescriptor,getOwnPropertyNames,getOwnPropertySymbols,getPrototypeOf,isExtensible,isFrozen,isSealed,keys,length,name,preventExtensions,prototype,seal,setPrototypeOf.
Was
arguments,caller,create,defineProperties,defineProperty,deliverChangeRecords,freeze,getNotifier,getOwnPropertyDescriptor,getOwnPropertyNames,getOwnPropertySymbols,getPrototypeOf,is,isExtensible,isFrozen,isSealed,keys,length,name,observe,preventExtensions,prototype,seal,setPrototypeOf,unobserve.
PASS getSortedOwnPropertyNames(Object.prototype) is
['__defineGetter__', '__defineSetter__', '__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty', 'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']
FAIL getSortedOwnPropertyNames(Function) should be length,name,prototype.
Was arguments,caller,length,name,prototype.
FAIL getSortedOwnPropertyNames(Function.prototype) should be
apply,bind,call,constructor,length,name,toString. Was
apply,arguments,bind,call,caller,constructor,length,name,toString.
Index: test/webkit/fast/js/Object-getOwnPropertyNames.js
diff --git a/test/webkit/fast/js/Object-getOwnPropertyNames.js
b/test/webkit/fast/js/Object-getOwnPropertyNames.js
index
6373cf1ae069c926150794bef0d9c527dd7d937b..fd00b3333aac74de77f79afbc2b836e6fcaacf83
100644
--- a/test/webkit/fast/js/Object-getOwnPropertyNames.js
+++ b/test/webkit/fast/js/Object-getOwnPropertyNames.js
@@ -71,7 +71,7 @@ var expectedPropertyNamesSet = {
"encodeURI": "['length', 'name']",
"encodeURIComponent": "['length', 'name']",
// Built-in ECMA objects
- "Object": "['create', 'defineProperties', 'defineProperty', 'freeze',
'getOwnPropertyDescriptor', 'getOwnPropertyNames', 'getPrototypeOf', 'isExtensible', 'isFrozen',
'isSealed', 'keys', 'length', 'name', 'preventExtensions', 'prototype', 'seal',
'setPrototypeOf']",
+ "Object": "['create', 'defineProperties', 'defineProperty', 'freeze',
'getOwnPropertyDescriptor', 'getOwnPropertyNames', 'getOwnPropertySymbols', 'getPrototypeOf',
'isExtensible', 'isFrozen', 'isSealed', 'keys', 'length', 'name', 'preventExtensions', 'prototype',
'seal', 'setPrototypeOf']",
"Object.prototype": "['__defineGetter__', '__defineSetter__',
'__lookupGetter__', '__lookupSetter__', '__proto__', 'constructor', 'hasOwnProperty',
'isPrototypeOf', 'propertyIsEnumerable', 'toLocaleString', 'toString', 'valueOf']",
"Function": "['length', 'name', 'prototype']",
"Function.prototype": "['apply', 'bind', 'call', 'constructor', 'length',
'name', 'toString']",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
