Reviewers: Weiliang, Toon Verwaest,
Message:
weiliang.
please review and commit this patch.
thanks.
Description:
X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs.
This patch contains one changes from R22802. In R22802 patch the X87 port
is
touched but it's not changed completely.
port r22805 & part of r22802.
original commit message:
Cleanup in stub-cache.cc; remove unused ArrayLength store ICs.
BUG=
Please review this at https://codereview.chromium.org/438163003/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+37, -54 lines):
M src/x87/stub-cache-x87.cc
Index: src/x87/stub-cache-x87.cc
diff --git a/src/x87/stub-cache-x87.cc b/src/x87/stub-cache-x87.cc
index
0574cb03a42f9fb24e3081e7a85ca3e55b782611..d87d5f06e6f821ae9a59473b640599ebdd1f6989
100644
--- a/src/x87/stub-cache-x87.cc
+++ b/src/x87/stub-cache-x87.cc
@@ -370,16 +370,6 @@ void PropertyHandlerCompiler::GenerateFastApiCall(
}
-void NamedStoreHandlerCompiler::GenerateRestoreName(MacroAssembler* masm,
- Label* label,
- Handle<Name> name) {
- if (!label->is_unused()) {
- __ bind(label);
- __ mov(this->name(), Immediate(name));
- }
-}
-
-
// Generate code to check that a global property cell is empty. Create
// the property cell at compilation time if no cell exists for the
// property.
@@ -401,13 +391,31 @@ void
PropertyHandlerCompiler::GenerateCheckPropertyCell(
}
+void PropertyAccessCompiler::GenerateTailCall(MacroAssembler* masm,
+ Handle<Code> code) {
+ __ jmp(code, RelocInfo::CODE_TARGET);
+}
+
+
+#undef __
+#define __ ACCESS_MASM(masm())
+
+
+void NamedStoreHandlerCompiler::GenerateRestoreName(Label* label,
+ Handle<Name> name) {
+ if (!label->is_unused()) {
+ __ bind(label);
+ __ mov(this->name(), Immediate(name));
+ }
+}
+
+
// Receiver_reg is preserved on jumps to miss_label, but may be destroyed
if
// store is successful.
void NamedStoreHandlerCompiler::GenerateStoreTransition(
- MacroAssembler* masm, LookupResult* lookup, Handle<Map> transition,
- Handle<Name> name, Register receiver_reg, Register storage_reg,
- Register value_reg, Register scratch1, Register scratch2, Register
unused,
- Label* miss_label, Label* slow) {
+ Handle<Map> transition, Handle<Name> name, Register receiver_reg,
+ Register storage_reg, Register value_reg, Register scratch1,
+ Register scratch2, Register unused, Label* miss_label, Label* slow) {
int descriptor = transition->LastAdded();
DescriptorArray* descriptors = transition->instance_descriptors();
PropertyDetails details = descriptors->GetDetails(descriptor);
@@ -415,7 +423,7 @@ void NamedStoreHandlerCompiler::GenerateStoreTransition(
DCHECK(!representation.IsNone());
if (details.type() == CONSTANT) {
- Handle<Object> constant(descriptors->GetValue(descriptor),
masm->isolate());
+ Handle<Object> constant(descriptors->GetValue(descriptor), isolate());
__ CmpObject(value_reg, constant);
__ j(not_equal, miss_label);
} else if (representation.IsSmi()) {
@@ -450,8 +458,8 @@ void NamedStoreHandlerCompiler::GenerateStoreTransition(
__ jmp(&do_store);
__ bind(&heap_number);
- __ CheckMap(value_reg, masm->isolate()->factory()->heap_number_map(),
- miss_label, DONT_DO_SMI_CHECK);
+ __ CheckMap(value_reg, isolate()->factory()->heap_number_map(),
miss_label,
+ DONT_DO_SMI_CHECK);
__ fld_d(FieldOperand(value_reg, HeapNumber::kValueOffset));
__ bind(&do_store);
@@ -473,9 +481,8 @@ void NamedStoreHandlerCompiler::GenerateStoreTransition(
__ push(scratch1);
__ TailCallExternalReference(
ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
- masm->isolate()),
- 3,
- 1);
+ isolate()),
+ 3, 1);
return;
}
@@ -563,12 +570,12 @@ void
NamedStoreHandlerCompiler::GenerateStoreTransition(
// Both name_reg and receiver_reg are preserved on jumps to miss_label,
// but may be destroyed if store is successful.
void NamedStoreHandlerCompiler::GenerateStoreField(
- MacroAssembler* masm, Handle<JSObject> object, LookupResult* lookup,
- Register receiver_reg, Register name_reg, Register value_reg,
- Register scratch1, Register scratch2, Label* miss_label) {
- // Stub never generated for non-global objects that require access
- // checks.
- DCHECK(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
+ Handle<JSObject> object, LookupResult* lookup, Register receiver_reg,
+ Register name_reg, Register value_reg, Register scratch1, Register
scratch2,
+ Label* miss_label) {
+ // Stub never generated for objects that require access checks.
+ DCHECK(!object->IsAccessCheckNeeded());
+ DCHECK(!object->IsJSGlobalProxy());
FieldIndex index = lookup->GetFieldIndex();
@@ -612,8 +619,8 @@ void NamedStoreHandlerCompiler::GenerateStoreField(
__ SmiTag(value_reg);
__ jmp(&do_store);
__ bind(&heap_number);
- __ CheckMap(value_reg, masm->isolate()->factory()->heap_number_map(),
- miss_label, DONT_DO_SMI_CHECK);
+ __ CheckMap(value_reg, isolate()->factory()->heap_number_map(),
miss_label,
+ DONT_DO_SMI_CHECK);
__ fld_d(FieldOperand(value_reg, HeapNumber::kValueOffset));
__ bind(&do_store);
__ fstp_d(FieldOperand(scratch1, HeapNumber::kValueOffset));
@@ -667,16 +674,6 @@ void NamedStoreHandlerCompiler::GenerateStoreField(
}
-void PropertyAccessCompiler::GenerateTailCall(MacroAssembler* masm,
- Handle<Code> code) {
- __ jmp(code, RelocInfo::CODE_TARGET);
-}
-
-
-#undef __
-#define __ ACCESS_MASM(masm())
-
-
Register PropertyHandlerCompiler::CheckPrototypes(
Register object_reg, Register holder_reg, Register scratch1,
Register scratch2, Handle<Name> name, Label* miss,
@@ -802,7 +799,7 @@ void
NamedStoreHandlerCompiler::FrontendFooter(Handle<Name> name, Label* miss) {
if (!miss->is_unused()) {
Label success;
__ jmp(&success);
- GenerateRestoreName(masm(), miss, name);
+ GenerateRestoreName(miss, name);
TailCallBuiltin(masm(), MissBuiltin(kind()));
__ bind(&success);
}
@@ -1115,20 +1112,6 @@ Handle<Code>
NamedStoreHandlerCompiler::CompileStoreInterceptor(
}
-void NamedStoreHandlerCompiler::GenerateStoreArrayLength() {
- // Prepare tail call to StoreIC_ArrayLength.
- __ pop(scratch1()); // remove the return address
- __ push(receiver());
- __ push(value());
- __ push(scratch1()); // restore return address
-
- ExternalReference ref =
- ExternalReference(IC_Utility(IC::kStoreIC_ArrayLength),
- masm()->isolate());
- __ TailCallExternalReference(ref, 2, 1);
-}
-
-
Handle<Code> PropertyICCompiler::CompileKeyedStorePolymorphic(
MapHandleList* receiver_maps, CodeHandleList* handler_stubs,
MapHandleList* transitioned_maps) {
@@ -1217,7 +1200,7 @@ void NamedLoadHandlerCompiler::GenerateLoadViaGetter(
Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
- Handle<PropertyCell> cell, Handle<Name> name, bool is_dont_delete) {
+ Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
Label miss;
FrontendHeader(receiver(), name, &miss);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
