https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isolate.h
File test/unittests/test-isolate.h (right):
https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isolate.h#newcode20
test/unittests/test-isolate.h:20: ~IsolateTest();
On 2014/08/05 07:36:19, jochen wrote:
i bet that needs to be virtual (and all other tests)
Done.
https://codereview.chromium.org/439863004/diff/20001/test/unittests/test-isolate.h#newcode27
test/unittests/test-isolate.h:27: };
On 2014/08/05 07:36:19, jochen wrote:
DISALLOW_COPY_AND_ASSIGN()....
Done.
https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.cc
File test/unittests/unittests.cc (right):
https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.cc#newcode19
test/unittests/unittests.cc:19: if (v8::V8::Initialize()) {
On 2014/08/05 07:36:19, jochen wrote:
consider doing less here as unit tests for base or libplatform won't
need any of
this. on the other hand it looks confusing as you don't set up ICU
which a
regular embedder would have to
Done.
https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.gyp
File test/unittests/unittests.gyp (right):
https://codereview.chromium.org/439863004/diff/20001/test/unittests/unittests.gyp#newcode20
test/unittests/unittests.gyp:20: 'compiler/compiler.h',
On 2014/08/05 07:36:19, jochen wrote:
it's a bit odd that this file doesn't have a test prefix while the
others do
Done.
https://codereview.chromium.org/439863004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
