LGTM once these comments have been addressed.
http://codereview.chromium.org/173016/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/173016/diff/1/2#newcode2246 Line 2246: #if defined(ANDROID) I don't think we need to hide this under #if defined(ANDROID). I think the method makes sense on other platforms as well. It should be entirely up to V8 what to do when we get this notification, so the documentation should be more abstract. Something along the lines of: "Optional notification that the system is running low on memory. V8 uses these notifications to attempt to free memory." Then the implementation can contain the #if defined(ANDROID) and do a full GC on the Android platform and do nothing on the other platforms for now. http://codereview.chromium.org/173016/diff/1/4 File src/heap.cc (right): http://codereview.chromium.org/173016/diff/1/4#newcode322 Line 322: bool saved_always_compact_flag = FLAG_always_compact; I would prefer to not use the flags to signal that a compacting collection is requested. http://codereview.chromium.org/173016/diff/1/5 File src/heap.h (right): http://codereview.chromium.org/173016/diff/1/5#newcode629 Line 629: // Performs a full garbage collection. Force compaction if the second if the second parameter -> if the parameter http://codereview.chromium.org/173016 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
