https://codereview.chromium.org/200443004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/200443004/diff/40001/src/heap/heap.cc#newcode3291
src/heap/heap.cc:3291: Object** zap =
reinterpret_cast<Object**>(object->address());
Please add a a method that is taking care of the zaping which is called
from both left and right trimming.
https://codereview.chromium.org/200443004/diff/40001/src/heap/heap.cc#newcode3374
src/heap/heap.cc:3374: // Force instantiation of template instances
class.
Please move the force instantiation before the actual instantiation.
https://codereview.chromium.org/200443004/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/200443004/diff/40001/src/heap/heap.h#newcode708
src/heap/heap.h:708: // Maintain consistency of live bytes during
incremental marking.
Move the enum before the comment and describe in a brief comment what
the enum is used for.
https://codereview.chromium.org/200443004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
