Reviewers: titzer, jochen,
Message:
Ben: PTAL. Jochen: Please check the mechanics of the DEPS files, you are
more
familiar with how they should be used.
Description:
Prevent direct inclusion of headers from TF.
[email protected]
Please review this at https://codereview.chromium.org/438243004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+19, -3 lines):
M src/DEPS
M src/compiler/pipeline.h
M src/compiler/pipeline.cc
M src/v8.cc
Index: src/DEPS
diff --git a/src/DEPS b/src/DEPS
index
2061869ab109b98f88102393f091f9f3b165b973..f38a902bdf0986ea80c1c762d8e1a4ab884035d0
100644
--- a/src/DEPS
+++ b/src/DEPS
@@ -1,5 +1,7 @@
include_rules = [
"+src",
+ "-src/compiler",
+ "+src/compiler/pipeline.h",
"-src/libplatform",
"-include/libplatform",
]
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index
a9a6cc4767a734e104bcd00abcf9c6b7945db5c8..1752882779c78fe7b2f3baf11e6172a140e9083f
100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -9,6 +9,7 @@
#include "src/compiler/code-generator.h"
#include "src/compiler/graph-replay.h"
#include "src/compiler/graph-visualizer.h"
+#include "src/compiler/instruction.h"
#include "src/compiler/instruction-selector.h"
#include "src/compiler/js-context-specialization.h"
#include "src/compiler/js-generic-lowering.h"
@@ -288,6 +289,16 @@ Handle<Code> Pipeline::GenerateCode(Linkage* linkage,
Graph* graph,
return generator.GenerateCode();
}
+
+void Pipeline::SetUp() {
+ InstructionOperand::SetUpCaches();
+}
+
+
+void Pipeline::TearDown() {
+ InstructionOperand::TearDownCaches();
+}
+
} // namespace compiler
} // namespace internal
} // namespace v8
Index: src/compiler/pipeline.h
diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h
index
f6dd39a34b6eb6b59335f4a5747ee4506f0f2296..4c1c0bcea9a20a278948484b63a007eb9a56e80f
100644
--- a/src/compiler/pipeline.h
+++ b/src/compiler/pipeline.h
@@ -50,6 +50,9 @@ class Pipeline {
#endif
}
+ static void SetUp();
+ static void TearDown();
+
private:
CompilationInfo* info_;
Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index
912356d8fa4d5f96f06793758c504ca9de80363c..e9db514907832c6cafdca8cfb6a0f19403b6c9a5
100644
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -8,7 +8,7 @@
#include "src/base/once.h"
#include "src/base/platform/platform.h"
#include "src/bootstrapper.h"
-#include "src/compiler/instruction.h"
+#include "src/compiler/pipeline.h"
#include "src/debug.h"
#include "src/deoptimizer.h"
#include "src/elements.h"
@@ -48,7 +48,7 @@ void V8::TearDown() {
Bootstrapper::TearDownExtensions();
ElementsAccessor::TearDown();
LOperand::TearDownCaches();
- compiler::InstructionOperand::TearDownCaches();
+ compiler::Pipeline::TearDown();
ExternalReference::TearDownMathExpData();
RegisteredExtension::UnregisterAll();
Isolate::GlobalTearDown();
@@ -90,7 +90,7 @@ void V8::InitializeOncePerProcessImpl() {
#endif
ElementsAccessor::InitializeOncePerProcess();
LOperand::SetUpCaches();
- compiler::InstructionOperand::SetUpCaches();
+ compiler::Pipeline::SetUp();
SetUpJSCallerSavedCodeData();
ExternalReference::SetUp();
Bootstrapper::InitializeOncePerProcess();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
