Replaced by http://codereview.chromium.org/173102
which add a global flag to MarkCompactCollector for forcing compaction. http://codereview.chromium.org/173016/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/173016/diff/1/2#newcode2246 Line 2246: #if defined(ANDROID) On 2009/08/19 17:24:23, Mads Ager wrote: > I don't think we need to hide this under #if defined(ANDROID). I think the > method makes sense on other platforms as well. > It should be entirely up to V8 what to do when we get this notification, so the > documentation should be more abstract. Something along the lines of: > "Optional notification that the system is running low on memory. V8 uses these > notifications to attempt to free memory." > Then the implementation can contain the #if defined(ANDROID) and do a full GC on > the Android platform and do nothing on the other platforms for now. Done. http://codereview.chromium.org/173016/diff/1/4 File src/heap.cc (right): http://codereview.chromium.org/173016/diff/1/4#newcode322 Line 322: bool saved_always_compact_flag = FLAG_always_compact; I had the same thought. There is no obvious way to do it now, how about a TODO here? On 2009/08/19 17:24:23, Mads Ager wrote: > I would prefer to not use the flags to signal that a compacting collection is > requested. http://codereview.chromium.org/173016 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
