On 2014/08/05 12:53:00, Yang wrote:
On 2014/08/05 11:47:15, Slava Chigrin wrote:
> Thank you so much for review! I tried to fix issues you found in new
patch
set.
>
> https://codereview.chromium.org/430213004/diff/20001/src/serialize.cc
> File src/serialize.cc (left):
>
>
https://codereview.chromium.org/430213004/diff/20001/src/serialize.cc#oldcode403
> src/serialize.cc:403: 39,
> I decided to not renumber all IDs after this, to avoid too big diff.
Seems,
> somebody already did the same (see IDs jump from 29 to 31 on line 371).
I
can
> perform renumbering, if you think it is worth it.
I think registering external references in the serializer is worth
policing,
so
I created this: https://codereview.chromium.org/441983002/
I checked your issue, it seems much more comprehensive then mine. I like
idea of
having script for automatic checking ExternalReferences registration. Thank
you
so much!
https://codereview.chromium.org/430213004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
