Revision: 22880
Author: [email protected]
Date: Tue Aug 5 14:19:22 2014 UTC
Log: Revert "Unbreak build with clang."
This reverts commit r22878 and fixes the actual bug instead.
[email protected]
Review URL: https://codereview.chromium.org/446573002
http://code.google.com/p/v8/source/detail?r=22880
Modified:
/branches/bleeding_edge/build/standalone.gypi
/branches/bleeding_edge/src/liveedit.cc
/branches/bleeding_edge/src/objects.h
/branches/bleeding_edge/src/types.h
=======================================
--- /branches/bleeding_edge/build/standalone.gypi Tue Aug 5 13:58:11 2014
UTC
+++ /branches/bleeding_edge/build/standalone.gypi Tue Aug 5 14:19:22 2014
UTC
@@ -216,7 +216,8 @@
or OS=="netbsd"', {
'target_defaults': {
'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wno-long-long', '-pthread', '-fno-exceptions' ],
+ '-Wno-long-long', '-pthread', '-fno-exceptions',
+ '-pedantic' ],
'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
'ldflags': [ '-pthread', ],
'conditions': [
=======================================
--- /branches/bleeding_edge/src/liveedit.cc Mon Aug 4 11:34:54 2014 UTC
+++ /branches/bleeding_edge/src/liveedit.cc Tue Aug 5 14:19:22 2014 UTC
@@ -174,7 +174,7 @@
static const int kDirectionSizeBits = 2;
static const int kDirectionMask = (1 << kDirectionSizeBits) - 1;
- static const int kEmptyCellValue = -1 << kDirectionSizeBits;
+ static const int kEmptyCellValue = ~0u << kDirectionSizeBits;
// This method only holds static assert statement (unfortunately you
cannot
// place one in class scope).
=======================================
--- /branches/bleeding_edge/src/objects.h Mon Aug 4 15:12:01 2014 UTC
+++ /branches/bleeding_edge/src/objects.h Tue Aug 5 14:19:22 2014 UTC
@@ -9005,7 +9005,8 @@
STATIC_ASSERT(IS_POWER_OF_TWO(kMaxCachedArrayIndexLength + 1));
static const unsigned int kContainsCachedArrayIndexMask =
- (~kMaxCachedArrayIndexLength << ArrayIndexLengthBits::kShift) |
+ (~static_cast<unsigned>(kMaxCachedArrayIndexLength)
+ << ArrayIndexLengthBits::kShift) |
kIsNotArrayIndexMask;
// Value of empty hash field indicating that the hash is not computed.
@@ -9089,7 +9090,8 @@
STATIC_ASSERT(IS_POWER_OF_TWO(kMaxCachedArrayIndexLength + 1));
static const unsigned int kContainsCachedArrayIndexMask =
- (~kMaxCachedArrayIndexLength << ArrayIndexLengthBits::kShift) |
+ (~static_cast<unsigned>(kMaxCachedArrayIndexLength)
+ << ArrayIndexLengthBits::kShift) |
kIsNotArrayIndexMask;
// Representation of the flat content of a String.
=======================================
--- /branches/bleeding_edge/src/types.h Tue Aug 5 13:19:32 2014 UTC
+++ /branches/bleeding_edge/src/types.h Tue Aug 5 14:19:22 2014 UTC
@@ -155,7 +155,8 @@
V(UntaggedFloat64, 1 << 27 | kSemantic) \
V(UntaggedPtr, 1 << 28 | kSemantic) \
V(TaggedInt, 1 << 29 | kSemantic) \
- V(TaggedPtr, -1 << 30 | kSemantic) /* MSB has to be
sign-extended */ \
+ /* MSB has to be sign-extended */ \
+ V(TaggedPtr, static_cast<int>(~0u << 30) | kSemantic) \
\
V(UntaggedInt, kUntaggedInt1 | kUntaggedInt8 | \
kUntaggedInt16 | kUntaggedInt32) \
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
