https://codereview.chromium.org/437393005/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/437393005/diff/1/src/types.cc#newcode283
src/types.cc:283: && *this->AsConstant()->Value() ==
*that->AsConstant()->Value();
Check value first, since that is faster.
https://codereview.chromium.org/437393005/diff/1/src/types.h
File src/types.h (right):
https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode517
src/types.h:517: static int RangeLub(double min, double max, TypeHandle
bound);
Is this defined anywhere?
https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode688
src/types.h:688: static bool le(double x, double y) {
These are helpers that shouldn't pollute the public interface. Maybe
just make them static global functions in types.cc?
https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode701
src/types.h:701: static int InherentLub(double min, double max) {
Rename/move this to BitsetType::Lub(double, double), since it's also
just an internal helper.
https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode704
src/types.h:704: if (min == max) {
eq(min, max)
https://codereview.chromium.org/437393005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
