https://codereview.chromium.org/444503005/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/444503005/diff/1/src/types.cc#newcode25
src/types.cc:25: for (int i = 0; i < unioned->Length(); ++i) {
You don't need this loop anymore: only the first element can be
non-None.
https://codereview.chromium.org/444503005/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):
https://codereview.chromium.org/444503005/diff/1/test/cctest/test-types.cc#newcode1323
test/cctest/test-types.cc:1323: OFStream os(stdout);
Yeah, I don't like committing this. Either all tests here should log
what they do or none.
https://codereview.chromium.org/444503005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
