Reviewers: Sven Panne,
Message:
PTAL
Description:
Move ARM64 macros to macro-assembler-arm64.h.
[email protected]
Please review this at https://codereview.chromium.org/444803003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -19 lines):
M src/arm64/macro-assembler-arm64.h
M src/checks.h
Index: src/arm64/macro-assembler-arm64.h
diff --git a/src/arm64/macro-assembler-arm64.h
b/src/arm64/macro-assembler-arm64.h
index
4092a27a641b75abc54e7153fc8d26b9283c1751..efb6bcfd4c6320c179ff1f5723768b0eba6b3901
100644
--- a/src/arm64/macro-assembler-arm64.h
+++ b/src/arm64/macro-assembler-arm64.h
@@ -11,6 +11,24 @@
#include "src/arm64/assembler-arm64-inl.h"
+// Simulator specific helpers.
+#if USE_SIMULATOR
+ // TODO(all): If possible automatically prepend an indicator like
+ // UNIMPLEMENTED or LOCATION.
+ #define
ASM_UNIMPLEMENTED(message) \
+ __ Debug(message, __LINE__, NO_PARAM)
+ #define
ASM_UNIMPLEMENTED_BREAK(message) \
+ __ Debug(message,
__LINE__, \
+ FLAG_ignore_asm_unimplemented_break ? NO_PARAM : BREAK)
+ #define
ASM_LOCATION(message) \
+ __ Debug("LOCATION: " message, __LINE__, NO_PARAM)
+#else
+ #define ASM_UNIMPLEMENTED(message)
+ #define ASM_UNIMPLEMENTED_BREAK(message)
+ #define ASM_LOCATION(message)
+#endif
+
+
namespace v8 {
namespace internal {
Index: src/checks.h
diff --git a/src/checks.h b/src/checks.h
index
146a33171950a86f0bd3438c66c4273a5cf23473..6303855fc862fe2c9a8aa603a2453211a37a3eac
100644
--- a/src/checks.h
+++ b/src/checks.h
@@ -7,25 +7,6 @@
#include "src/base/logging.h"
-// Simulator specific helpers.
-// We can't use USE_SIMULATOR here because it isn't defined yet.
-#if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
- // TODO(all): If possible automatically prepend an indicator like
- // UNIMPLEMENTED or LOCATION.
- #define
ASM_UNIMPLEMENTED(message) \
- __ Debug(message, __LINE__, NO_PARAM)
- #define
ASM_UNIMPLEMENTED_BREAK(message) \
- __ Debug(message,
__LINE__, \
- FLAG_ignore_asm_unimplemented_break ? NO_PARAM : BREAK)
- #define
ASM_LOCATION(message) \
- __ Debug("LOCATION: " message, __LINE__, NO_PARAM)
-#else
- #define ASM_UNIMPLEMENTED(message)
- #define ASM_UNIMPLEMENTED_BREAK(message)
- #define ASM_LOCATION(message)
-#endif
-
-
#ifdef DEBUG
#ifndef OPTIMIZED_DEBUG
#define ENABLE_SLOW_DCHECKS 1
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
