LGTM with comments.
https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h#newcode987
src/code-stubs.h:987: ;
I don't think this is needed
https://codereview.chromium.org/443873002/diff/2/src/code-stubs.h#newcode1005
src/code-stubs.h:1005: Representation representation_;
Are you intentionally storing the representation twice (in
representation_ as well as bit_field_)?
https://codereview.chromium.org/443873002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
