Revision: 2728 Author: [email protected] Date: Thu Aug 20 01:12:30 2009 Log: Go back to doubling the size when growing new space.
Our memory tests show little improvement by only growing by 50%. Review URL: http://codereview.chromium.org/174133 http://code.google.com/p/v8/source/detail?r=2728 Modified: /branches/bleeding_edge/src/spaces.cc /branches/bleeding_edge/src/v8.cc ======================================= --- /branches/bleeding_edge/src/spaces.cc Wed Aug 19 03:36:19 2009 +++ /branches/bleeding_edge/src/spaces.cc Thu Aug 20 01:12:30 2009 @@ -1079,9 +1079,9 @@ bool SemiSpace::Grow() { - // Commit 50% extra space but only up to maximum capacity. + // Double the semispace size but only up to maximum capacity. int maximum_extra = maximum_capacity_ - capacity_; - int extra = Min(RoundUp(capacity_ / 2, OS::AllocateAlignment()), + int extra = Min(RoundUp(capacity_, OS::AllocateAlignment()), maximum_extra); if (!MemoryAllocator::CommitBlock(high(), extra, executable())) { return false; ======================================= --- /branches/bleeding_edge/src/v8.cc Thu Aug 13 05:03:42 2009 +++ /branches/bleeding_edge/src/v8.cc Thu Aug 20 01:12:30 2009 @@ -155,6 +155,7 @@ lo = 18273 * (lo & 0xFFFF) + (lo >> 16); return (hi << 16) + (lo & 0xFFFF); } + void V8::IdleNotification(bool is_high_priority) { if (!FLAG_use_idle_notification) return; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
