https://codereview.chromium.org/443933002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/443933002/diff/1/BUILD.gn#newcode659
BUILD.gn:659: "src/heap/objects-visiting.cc",
nit: Can we add the "-inl.h" file as well?
https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (right):
https://codereview.chromium.org/443933002/diff/1/src/heap/objects-visiting-inl.h#newcode870
src/heap/objects-visiting-inl.h:870: void Code::CodeIterateBody(Heap*
heap) {
Please keep this static visitor method near the virtual dispatch visitor
(as discussed offline) in the objects-inl.h file.
https://codereview.chromium.org/443933002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/443933002/diff/1/src/objects.cc#newcode11561
src/objects.cc:11561: void Code::CodeIterateBody(ObjectVisitor* v) {
Would it be possible to move this into the objects-inl.h file?
https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/443933002/diff/1/tools/gyp/v8.gyp#newcode560
tools/gyp/v8.gyp:560: '../../src/heap/objects-visiting.cc',
nit: Can we add the "-inl.h" file as well?
https://codereview.chromium.org/443933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
