Reviewers: Jakob,
Description:
Drop bogus default parameter to BuildFunctionInfo.
[email protected]
Please review this at https://codereview.chromium.org/448653002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -5 lines):
M src/compiler.h
M src/compiler/ast-graph-builder.cc
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index
a6397147f0254f1580563f485646e48c4573274d..e8beca5a05a68f2230108bec4127c16f5ef189f1
100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -692,9 +692,9 @@ class Compiler : public AllStatic {
NativesFlag is_natives_code);
// Create a shared function info object (the code may be lazily
compiled).
- static Handle<SharedFunctionInfo> BuildFunctionInfo(
- FunctionLiteral* node, Handle<Script> script,
- CompilationInfo* outer = NULL);
+ static Handle<SharedFunctionInfo> BuildFunctionInfo(FunctionLiteral*
node,
+ Handle<Script>
script,
+ CompilationInfo*
outer);
enum ConcurrencyMode { NOT_CONCURRENT, CONCURRENT };
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc
b/src/compiler/ast-graph-builder.cc
index
383ac93924fc61ab41003b51dd2635bbfc1a52e6..9495a211a498a6eab6f75074477727a4f53b6c35
100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -386,7 +386,7 @@ void
AstGraphBuilder::VisitFunctionDeclaration(FunctionDeclaration* decl) {
switch (variable->location()) {
case Variable::UNALLOCATED: {
Handle<SharedFunctionInfo> function =
- Compiler::BuildFunctionInfo(decl->fun(), info()->script());
+ Compiler::BuildFunctionInfo(decl->fun(), info()->script(),
info());
// Check for stack-overflow exception.
if (function.is_null()) return SetStackOverflow();
globals()->Add(variable->name(), zone());
@@ -787,7 +787,7 @@ void
AstGraphBuilder::VisitFunctionLiteral(FunctionLiteral* expr) {
Handle<SharedFunctionInfo> shared_info =
SearchSharedFunctionInfo(info()->shared_info()->code(), expr);
if (shared_info.is_null()) {
- shared_info = Compiler::BuildFunctionInfo(expr, info()->script());
+ shared_info = Compiler::BuildFunctionInfo(expr, info()->script(),
info());
CHECK(!shared_info.is_null()); // TODO(mstarzinger): Set stack
overflow?
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
