Revision: 22929
Author:   [email protected]
Date:     Wed Aug  6 13:09:34 2014 UTC
Log:      Drop bogus default parameter to BuildFunctionInfo.

[email protected]

Review URL: https://codereview.chromium.org/448653002
http://code.google.com/p/v8/source/detail?r=22929

Modified:
 /branches/bleeding_edge/src/compiler/ast-graph-builder.cc
 /branches/bleeding_edge/src/compiler.h

=======================================
--- /branches/bleeding_edge/src/compiler/ast-graph-builder.cc Wed Aug 6 11:49:02 2014 UTC +++ /branches/bleeding_edge/src/compiler/ast-graph-builder.cc Wed Aug 6 13:09:34 2014 UTC
@@ -404,7 +404,7 @@
   switch (variable->location()) {
     case Variable::UNALLOCATED: {
       Handle<SharedFunctionInfo> function =
-          Compiler::BuildFunctionInfo(decl->fun(), info()->script());
+ Compiler::BuildFunctionInfo(decl->fun(), info()->script(), info());
       // Check for stack-overflow exception.
       if (function.is_null()) return SetStackOverflow();
       globals()->Add(variable->name(), zone());
@@ -805,7 +805,7 @@
   Handle<SharedFunctionInfo> shared_info =
       SearchSharedFunctionInfo(info()->shared_info()->code(), expr);
   if (shared_info.is_null()) {
-    shared_info = Compiler::BuildFunctionInfo(expr, info()->script());
+ shared_info = Compiler::BuildFunctionInfo(expr, info()->script(), info()); CHECK(!shared_info.is_null()); // TODO(mstarzinger): Set stack overflow?
   }

=======================================
--- /branches/bleeding_edge/src/compiler.h      Mon Aug  4 11:34:54 2014 UTC
+++ /branches/bleeding_edge/src/compiler.h      Wed Aug  6 13:09:34 2014 UTC
@@ -692,9 +692,9 @@
       NativesFlag is_natives_code);

// Create a shared function info object (the code may be lazily compiled).
-  static Handle<SharedFunctionInfo> BuildFunctionInfo(
-      FunctionLiteral* node, Handle<Script> script,
-      CompilationInfo* outer = NULL);
+ static Handle<SharedFunctionInfo> BuildFunctionInfo(FunctionLiteral* node, + Handle<Script> script, + CompilationInfo* outer);

   enum ConcurrencyMode { NOT_CONCURRENT, CONCURRENT };

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to