Reviewers: Weiliang, Yang,
Message:
weiliang.
please review and commit this patch.
thanks.
Description:
X87: Check that external references are registered in the serializer.
port r22896
original commit message:
Check that external references are registered in the serializer.
Inspired by a patch by Slava Chigrin <[email protected]>;
BUG=
Please review this at https://codereview.chromium.org/446003004/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+1, -0 lines):
M src/x87/macro-assembler-x87.cc
Index: src/x87/macro-assembler-x87.cc
diff --git a/src/x87/macro-assembler-x87.cc b/src/x87/macro-assembler-x87.cc
index
07f0fed0da33ad7c1eaec1825c9ea277432ec3b9..6196d8f7ae468ea2e65077818989e16f903729d6
100644
--- a/src/x87/macro-assembler-x87.cc
+++ b/src/x87/macro-assembler-x87.cc
@@ -3015,6 +3015,7 @@ void MacroAssembler::CheckPageFlagForMap(
Label::Distance condition_met_distance) {
DCHECK(cc == zero || cc == not_zero);
Page* page = Page::FromAddress(map->address());
+ DCHECK(!serializer_enabled()); // Serializer cannot match page_flags.
ExternalReference reference(ExternalReference::page_flags(page));
// The inlined static address check of the page's flags relies
// on maps never being compacted.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
